update criu to 2.10 #1319
Closed
update criu to 2.10 #1319
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@avagin @crosbymichael failure in jenkins look weird. Does the builder have ipv6 ? If not ( i assume), shouldnt criu detect and not doing ip6tables-restore ? |
Contributor
|
CRIU tried to lock network traffic: |
Contributor
|
CRIU blocks ipv6 traffic if /proc/sys/net/ipv6 exists... |
When running the tests under overlay2, criu failed to parse mountinfo and return the following log ``` (00.009971) 1: type overlay source overlay mnt_id 309 s_dev 0x32 / @ ./ flags 0x200000 options seclabel,lowerdir=/var/lib/docker/overlay2/l/PYTCIQRNYY5T6DD3YV4F6URSNN:/var/lib/docker/overlay2/l/GQ7SZUXXXIO46JPSD3JCYRWTRL:/var/lib/docker/overlay2/l/P4PLTJCCERJJEXJ32J7B5CQXFM:/var/lib/docker/overlay2/l/5UCCLJKJMBUWOHZJUF4WWRKYL2:/var/lib/docker/overlay2/l/GSTVOU3X2AMMLQMLVB2QGQK6PA:/var/lib/docker/overlay2/l/SNMSZYAVJDXHZFGA2Q5KEO3EFQ:/var/lib/docker/overlay2/l/O2SK4T6N5OQAIRWOUJ5TR6BZUW:/var/lib/docker/overlay2/l/YCB5Z54JCI2KIRV4EAIYL6YVYW:/var/lib/docker/overlay2/l/OECEHKQA6DB5EBAHKFANECBPYQ:/var/lib/docker/overlay2/l/VGJYCB3U4FU3Z7YEVSAL42IJAS:/var/lib/docker/overlay2/l/4G6XUVDRFZ6YYMUH66TQQDXNWO:/var/lib/docker/overlay2/l/KD62VJNIAIA2IIAL6WPOEXBRWA:/var/lib/docker/overlay2/l/QCMHENA34ODPEO3ZAPH3FK2OCD:/var/lib/docker/overlay2/l/RRDTDKVUR2V25YTJOLHR3TLBTD:/var/lib/docker/overlay2/l/7226SNFBM2R6XOQ2WAMSBKZSBI:/var/lib/docker/overlay2/l/J5EWEIFPTC66NOKTXHHVVRT43C:/var/lib/docker/overlay2/l/D53SRXCVRCCIGQWD7MOAUIPDRF,upperdir=/var/lib/docker/overlay2/87e (00.010001) 1: Error (proc_parse.c:1151): Bad format in 0 mountinfo: '739dac4ad853b7873c725664d89b423c08db81e903c21815d0fda4b29fc85/diff,workdir=/var/lib/docker/overlay2/87e739dac4ad853b7873c725664d89b423c08db81e903c21815d0fda4b29fc85/work ' (00.010009) 1: Error (mount.c:1642): Can't parse 0's mountinfo (00.025661) Error (cr-restore.c:1933): Restoring FAILED. ``` criu upstream added a workaround xemul/criu@fb4f28f This upgrades out current criu in test to the latest version. Fixes: opencontainers#1070 Signed-off-by: Daniel Dao <[email protected]>
dqminh
force-pushed
the
fix-restore-overlay2
branch
from
efe9fed to
bd2133b
Compare
Contributor
Author
|
@avagin yah im not sure actually. building locally works for me. @crosbymichael can we retry the jenkins build ? |
Contributor
Author
|
Closing because #1355 also does this and more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running the tests under overlay2, criu failed to parse mountinfo
and return the following log
criu upstream added a workaround xemul/criu@fb4f28f
This upgrades out current criu in test to the latest version.
Fixes: #1070